Make GetPathRelativeTo() resolve symbolic links #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infraredgirl
requested review from
brikis98,
ellisonc,
arsci,
zackproser,
pete0emerson and
james03160927
as code owners
zackproser
reviewed
Oct 25, 2022
|
Thanks for the review, Zack! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #75.
Without this change the relative paths are not computed correctly in case when
basePathis a subfolder ofpath, and one of them is a symbolic link of the other.Note that I had to create fixtures for test cases of
GetPathRelativeTo(), because thefilepath.EvalSymlinks()method that we're now using is actually looking for files on disk.